E2E: Add additional checks to verify if the components are ready #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
google-oss-prow
bot
requested review from
anencore94,
gaocegege and
johnugeorge
tenzen-y
commented
Aug 13, 2023
tenzen-y
commented
Aug 13, 2023
tenzen-y
force-pushed
the
fix-flaky-e2e
branch
3 times, most recently
from
5f9095f to
e95f4f6
Compare
tenzen-y
force-pushed
the
fix-flaky-e2e
branch
from
e95f4f6 to
64851da
Compare
tenzen-y
force-pushed
the
fix-flaky-e2e
branch
6 times, most recently
from
d2e0a1d to
0f57b3c
Compare
tenzen-y
force-pushed
the
fix-flaky-e2e
branch
2 times, most recently
from
e64253e to
8691375
Compare
tenzen-y
commented
Aug 13, 2023
| TIMEOUT=120s | ||
| kubectl wait --for=condition=ready --timeout=${TIMEOUT} -l "katib.kubeflow.org/component in ($WITH_DATABASE_TYPE,controller,db-manager,ui)" -n kubeflow pod || | ||
|
|
||
| kubectl wait --for=condition=ContainersReady=True --timeout=${TIMEOUT} -l "katib.kubeflow.org/component in ($WITH_DATABASE_TYPE,controller,db-manager,ui)" -n kubeflow pod || |
There was a problem hiding this comment.
The --for=condition=ready option doesn't confirm if all containers are ready:
/home/runner/work/katib/katib/test/e2e/v1beta1/scripts/gh-actions
pod/katib-db-manager-756ff4d844-wrs27 condition met
All Katib components are running.
Katib deployments
NAME READY UP-TO-DATE AVAILABLE AGE
katib-controller 0/1 0 0 2s
katib-db-manager 1/1 1 1 2s
katib-mysql 0/1 0 0 2shttps://github.com/kubeflow/katib/actions/runs/5842762640/job/15844213190?pr=2201#step:4:5605
tenzen-y
force-pushed
the
fix-flaky-e2e
branch
2 times, most recently
from
cef41c0 to
7d28b7f
Compare
|
/lgtm |
Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
tenzen-y
force-pushed
the
fix-flaky-e2e
branch
from
7d28b7f to
504fa1c
Compare
|
New changes are detected. LGTM label has been removed. |
tenzen-y
added a commit
to tenzen-y/katib
that referenced
this pull request
Aug 16, 2023
…eflow#2202) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
1 task
google-oss-prow bot
pushed a commit
that referenced
this pull request
Aug 16, 2023
…if the components are ready (#2212) Signed-off-by: Yuki Iwai <yuki.iwai.tz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
To fix flaky E2E, I added additional checks to verify if the components are ready.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Checklist: