Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install typing-extensions v4.6.3 for Optuna #2251

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

tenzen-y
Copy link
Member

@tenzen-y tenzen-y commented Jan 3, 2024

What this PR does / why we need it:
We need to install typing-extensions v4.6.0 or newer to resolve the following CI error:

E ImportError: cannot import name 'TypeAliasType' from 'typing_extensions' (/opt/hostedtoolcache/Python/3.9.18/x64/lib/python3.9/site-packages/typing_extensions.py)

https://github.com/kubeflow/katib/actions/runs/7400396607/job/20133921603?pr=2250#step:4:594

The root cause is that the sqlalchemy on which the optuna depends requires typing-extensions v4.6.0 or newer:

Optuna dependencies: https://github.com/optuna/optuna/blob/v3.3.0/pyproject.toml#L40

sqlalchemy dependencies: https://github.com/sqlalchemy/sqlalchemy/blob/4871a2f72f5f0e514fe81a8caa17a14f9fc51300/setup.cfg#L38-L39

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Checklist:

  • Docs included if any changes are user facing

Signed-off-by: tenzen-y <yuki.iwai.tz@gmail.com>
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tenzen-y
Copy link
Member Author

tenzen-y commented Jan 3, 2024

/assign @andreyvelich @johnugeorge

This PR is blocking all PRs.

Copy link
Member

@andreyvelich andreyvelich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @tenzen-y!
/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jan 4, 2024
@google-oss-prow google-oss-prow bot merged commit 75ea35c into kubeflow:master Jan 4, 2024
59 checks passed
@tenzen-y tenzen-y deleted the fix-python-lint-error branch January 4, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants