Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix slice range #226

Merged
merged 1 commit into from
Oct 28, 2018
Merged

fix slice range #226

merged 1 commit into from
Oct 28, 2018

Conversation

ytetra
Copy link
Contributor

@ytetra ytetra commented Oct 25, 2018

Fix slice range when minimize optimization, in this PR.
This prevents "index out of range" of tids from occurring in later for loops.


This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@ytetra
Copy link
Contributor Author

ytetra commented Oct 26, 2018

I signed it

@googlebot
Copy link

CLAs look good, thanks!

@YujiOshima
Copy link
Contributor

@ytetra Thanks!
/ok-to-test

@YujiOshima
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 7eeea12 into kubeflow:master Oct 28, 2018
@ytetra ytetra deleted the algo_hyperband branch October 29, 2018 08:46
@ytetra ytetra restored the algo_hyperband branch October 29, 2018 08:46
@ytetra ytetra deleted the algo_hyperband branch December 3, 2018 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants