Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace gRPC code generation tool from Znly/protoc to Buf #2277

Closed
wants to merge 2 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions cmd/db-manager/v1beta1/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,8 @@ const (
var dbIf common.KatibDBInterface

type server struct {
api_pb.UnimplementedDBManagerServer
health_pb.UnimplementedHealthServer
}

// Report a log of Observations for a Trial.
Expand Down
1 change: 1 addition & 0 deletions cmd/suggestion/goptuna/v1beta1/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ const (
)

type healthService struct {
health_pb.UnimplementedHealthServer
}

func (s *healthService) Check(ctx context.Context, in *health_pb.HealthCheckRequest) (*health_pb.HealthCheckResponse, error) {
Expand Down
27 changes: 27 additions & 0 deletions pkg/apis/manager/health/buf.gen.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,27 @@
version: v1
managed:
enabled: true
go_package_prefix:
default: github.com/kubeflow/katib/.
except:
- buf.build/googleapis/googleapis
plugins:
- plugin: buf.build/grpc/go:v1.3.0
out: ./
opt:
- paths=source_relative
# Choose one of the following protocol buffers plugin configurations
# based on your requirements
- plugin: buf.build/protocolbuffers/go:v1.33.0
out: ./
opt:
- paths=source_relative
# OR
# - plugin: buf.build/protocolbuffers/go
# out: ./
# opt:
# - paths=source_relative
- plugin: buf.build/grpc/python:v1.62.0
out: python
- plugin: buf.build/protocolbuffers/python
out: python
7 changes: 7 additions & 0 deletions pkg/apis/manager/health/buf.yaml
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
version: v1
breaking:
use:
- FILE
lint:
use:
- DEFAULT
24 changes: 0 additions & 24 deletions pkg/apis/manager/health/build.sh

This file was deleted.

Loading
Loading