Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old-style TensorFlow events (tensorboard) #2467

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

garymm
Copy link

@garymm garymm commented Dec 18, 2024

Fixes: #2466

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gaocegege for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@garymm
Copy link
Author

garymm commented Dec 18, 2024

I didn't see a place to add tests for this code. Is there a good place to add tests? If so, I'm happy to do it.

Also unrelated to this bug, but while testing I found it pretty surprising that you consider an event to match as long as the tag name starts with the metric name (e.g. a TF Event with tag "foobar" will match a metric name "foo"). Is this intended? Seems sort of surprising. If that's not intended, I can open another PR to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TensorFlowEvent metrics collector doesn't find events written by torch / tensorboardX
1 participant