Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix timing to determine slice size in grid search #271

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

ytetra
Copy link
Contributor

@ytetra ytetra commented Dec 3, 2018

Fix timing to determine slice size. With this fix, error due to the empty part of the slice doesn't occur.
(Fixes: #215)


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @ytetra. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YujiOshima
Copy link
Contributor

/ok-to-test

@YujiOshima
Copy link
Contributor

/retest

@YujiOshima
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YujiOshima

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@YujiOshima
Copy link
Contributor

/retest

@k8s-ci-robot k8s-ci-robot merged commit 55f125c into kubeflow:master Dec 5, 2018
@ytetra ytetra deleted the grid_fix branch December 21, 2018 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failed to run Grid search example
3 participants