-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properly initialize CI cluster credential #360
Conversation
Hi @toshiiw. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
2047585
to
225feef
Compare
It gave an error in run-tests.sh. |
/retest |
1 similar comment
/retest |
@toshiiw Please rebase the latest master. |
225feef
to
0ed5f6a
Compare
@toshiiw Is this similar to the issue you had? kubernetes/ingress-nginx#1663 Can you try something like kubernetes/ingress-nginx#1663 (comment)? |
Is there a plan to run Katib in its own cluster. Since Katib includes cluster resources (e.g. StudyJob controller) we will inevitably have conflicts if multiple tests try to make changes and test those changes? Are we using kfctl.sh to deploy Katib? |
@jlewi Katib is currently not using kfctl. We are applying katib components directly to the cluster: https://github.com/kubeflow/katib/blob/master/scripts/deploy.sh |
0ed5f6a
to
688faf0
Compare
688faf0
to
834d7dc
Compare
It has been using the cluster where argo ran
834d7dc
to
33e63fb
Compare
/hold cancel |
@toshiiw Great! Thanks! |
@toshiiw Can you sign the CLA and reply with "I signed it"? |
@richardsliu I signed it a while ago. I'm not sure why cla/google bot is complaining now. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
1 similar comment
/retest |
The infra isn't in a good shape, it seems.
|
/retest |
It has been using the cluster where argo ran
Hopefully fixes #359
This change is