Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly initialize CI cluster credential #360

Merged
merged 1 commit into from
Feb 14, 2019

Conversation

toshiiw
Copy link
Contributor

@toshiiw toshiiw commented Feb 1, 2019

It has been using the cluster where argo ran

Hopefully fixes #359


This change is Reviewable

@k8s-ci-robot
Copy link

Hi @toshiiw. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@YujiOshima
Copy link
Contributor

/ok-to-test

@toshiiw
Copy link
Contributor Author

toshiiw commented Feb 4, 2019

It gave an error in run-tests.sh.
The credential set up by this patch seemed to be incapable of creating new clusterrolebindings.
Helps appreciated.

@richardsliu
Copy link
Contributor

/retest

1 similar comment
@richardsliu
Copy link
Contributor

/retest

@YujiOshima
Copy link
Contributor

@toshiiw Please rebase the latest master.

@richardsliu
Copy link
Contributor

@toshiiw Is this similar to the issue you had? kubernetes/ingress-nginx#1663

Can you try something like kubernetes/ingress-nginx#1663 (comment)?

@jlewi
Copy link
Contributor

jlewi commented Feb 11, 2019

Is there a plan to run Katib in its own cluster. Since Katib includes cluster resources (e.g. StudyJob controller) we will inevitably have conflicts if multiple tests try to make changes and test those changes?

Are we using kfctl.sh to deploy Katib?

@richardsliu
Copy link
Contributor

@jlewi Katib is currently not using kfctl. We are applying katib components directly to the cluster: https://github.com/kubeflow/katib/blob/master/scripts/deploy.sh

It has been using the cluster where argo ran
@toshiiw
Copy link
Contributor Author

toshiiw commented Feb 13, 2019

/hold cancel

@YujiOshima
Copy link
Contributor

@toshiiw Great! Thanks!
@richardsliu Could we merge this?

@richardsliu
Copy link
Contributor

@toshiiw Can you sign the CLA and reply with "I signed it"?

@toshiiw
Copy link
Contributor Author

toshiiw commented Feb 14, 2019

@richardsliu I signed it a while ago. I'm not sure why cla/google bot is complaining now.

@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@toshiiw
Copy link
Contributor Author

toshiiw commented Feb 14, 2019

/retest

1 similar comment
@YujiOshima
Copy link
Contributor

/retest

@toshiiw
Copy link
Contributor Author

toshiiw commented Feb 14, 2019

The infra isn't in a good shape, it seems.

ERROR: (gcloud.builds.submit) [Errno 104] Connection reset by peer
This may be due to network connectivity issues. Please check your network settings, and the status
of the service you are trying to reach.

@toshiiw
Copy link
Contributor Author

toshiiw commented Feb 14, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit a5c8e02 into kubeflow:master Feb 14, 2019
@toshiiw toshiiw deleted the fix-ci-cluster branch February 14, 2019 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI seems to be running on somewhere else than $CLUSTER_NAME
5 participants