-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bayesian optimization draft #38
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
/assign @gaocegege @YujiOshima |
CLAs look good, thanks! |
/hold |
Thanks for your awesome contribution! I will take a look soon. |
When the PR is ready to merge, please use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. @YujiOshima I think we should support python suggestion by default thus we could refer to the implementation in other systems, e.g. https://github.com/tobegit3hub/advisor
suggestion/python/README.md
Outdated
|
||
- start the testing client | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the new line here.
suggestion/python/api/api.proto
Outdated
|
||
service Suggestion { | ||
rpc GenerateTrials(GenerateTrialsRequest) returns (GenerateTrialsReply); | ||
rpc SetSuggestionParameters(SetSuggestionParametersRequest) returns (SetSuggestionParametersReply); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent blanks here. Please fix it.
/ok-to-test Please rebase the master and I think the test should pass. |
suggestion/python/api/api.proto
Outdated
@@ -0,0 +1,246 @@ | |||
syntax = "proto3"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should use /api/api.proto.
We should generate suggestion API from the same file not to make inconsistency between go and python.
@libbyandhelen Please move |
@libbyandhelen And please dockerize your suggestion service and add k8s manifest. |
@libbyandhelen If you have any question about |
/hold cancel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you may have discussions with @YujiOshima about api proto. Thus I only reviewed other code and LGTM.
Thanks
@gaocegege OK, got it. |
@libbyandhelen OK, we will add DB interface for python later. |
I think it is the last step! 🎉 Thanks for your contribution! |
@libbyandhelen Thank you for your great contribution! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YujiOshima The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is a draft for bayesian optimization (work in progress) #15 @gaocegege @YujiOshima