-
Notifications
You must be signed in to change notification settings - Fork 448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NAS Envelopenet Suggestion and Job Example #425
Conversation
outputSize: | ||
- 10 | ||
operations: | ||
- operationType: envolpenet |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
envolpenet -> envelopenet
@richardsliu @andreyvelich Please review and close this. |
|
||
|
||
def serve(): | ||
print("NAS Envelopenet Suggestion Service") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, you should change print to logging, like here: https://github.com/kubeflow/katib/blob/master/pkg/suggestion/v1alpha1/nasrl_service.py#L51
Can you include a README with this example? Also is it based on this paper? https://arxiv.org/pdf/1803.06744.pdf If so please link it here. |
@richardsliu done |
/retest |
@richardsliu Plz merge |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This PR is about NAS algorithm Envelopenet https://arxiv.org/pdf/1803.06744.pdf. I will add Training container PR separately. TODO: Multiple studyjobs and trials support.
This change is