Add metrics collector spec and objective spec to Trial #489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnugeorge
reviewed
May 8, 2019
| @@ -29,6 +29,9 @@ type TrialSpec struct { | |||
| // and let the corresponding resource controller (e.g. tf-operator) handle | |||
| // the rest. | |||
| RunSpec string `json:"runSpec,omitempty"` | |||
|
|
|||
| // Raw text for the metrics collector spec. This must be a CronJob object. | |||
| MetricsCollectorSpec string `json:"metricsCollectorSpec,omitempty"` | |||
There was a problem hiding this comment.
add Objective name and type to spec to figure out the best values?
There was a problem hiding this comment.
Added ObjectiveSpec to Trial.
richardsliu
changed the title
|
/assign @johnugeorge |
|
/assign @gaocegege |
hougangliu
reviewed
May 8, 2019
|
/lgtm |
johnugeorge
reviewed
May 9, 2019
gaocegege
reviewed
May 9, 2019
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: johnugeorge The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #442
Adding some fields to Trial CRD:
This change is