Updated makefile by adding more targets for developer. #575
Conversation
| ``` | ||
|
|
||
| You can build all images from source. | ||
|
|
||
| ```bash | ||
| ./scripts/v1alpha1/build.sh | ||
| make build |
There was a problem hiding this comment.
can you refactor it to add version arg to bash scripts/v1alpha1/build.sh or bash scripts/v1alpha2/build.sh
There was a problem hiding this comment.
My thinking is as follows, I will try to update makefile when v1alpha2 become stable by making make build to build v1alpha2 and introduce another make build-v1alpha1 to build the old v1alpha1 version.
But for now, I want to use make build default to v1alpha1 as v1alpha2 is not ready yet, comments?
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
/cc @hougangliu @gaocegege @richardsliu
This change is