Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check error in OpenSQLConnection #588

Merged
merged 3 commits into from
May 28, 2019
Merged

Check error in OpenSQLConnection #588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
45c68a1
Check error in openSQLconn
andreyvelich May 25, 2019
123bd97
Add logic in v1alpha1
andreyvelich May 25, 2019
239012b
Change to Errorf
andreyvelich May 27, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pkg/db/v1alpha1/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,9 @@ func openSQLConn(driverName string, dataSourceName string, interval time.Duratio
if err = db.Ping(); err == nil {
return db, nil
}
klog.Errorf("Ping to Katib db failed: %v", err)
} else {
klog.Errorf("Open sql connection failed: %v", err)
}
case <-timeoutC:
return nil, fmt.Errorf("Timeout waiting for DB conn successfully opened.")
Expand Down
3 changes: 3 additions & 0 deletions pkg/db/v1alpha2/interface.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,9 @@ func openSQLConn(driverName string, dataSourceName string, interval time.Duratio
if err = db.Ping(); err == nil {
return db, nil
}
klog.Errorf("Ping to Katib db failed: %v", err)
} else {
klog.Errorf("Open sql connection failed: %v", err)
}
case <-timeoutC:
return nil, fmt.Errorf("Timeout waiting for DB conn successfully opened.")
Expand Down