Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled make check in travis. #608

Merged
merged 2 commits into from
May 29, 2019
Merged

Enabled make check in travis. #608

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39153ad
Enabled make check in travis.
gyliu513 May 29, 2019
df2978b
Upgrade to go 1.12.5 for travis.
gyliu513 May 29, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
language: go

go:
- "1.10"
- "1.11"
- "1.12"
- "1.12.5"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use 1.12 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I followed kubefed here kubernetes-retired/kubefed#902 , it is always good to use latest stable version.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I do not think so. I think we should support multiple go versions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Different go version sometimes have different standard. In my previous PR, I found that gofmt always failed in go1.10 but succeed in go 1.12 and go 1.11, this caused the make check failed. Using the latest go can leverage the latest features in Go.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, go 1.10 can be removed. Format check may be failed in 1.10. I also noticed it.


go_import_path: github.com/kubeflow/katib

Expand All @@ -17,5 +15,6 @@ install:
- go get github.com/mattn/goveralls

script:
- make check
- make test
- goveralls -coverprofile=coverage.out