Set trial completion status only after metric collection

[johnugeorge]

Fixes: #615

Trial status is updated only if trial observation field is updated. (This will be set if metrics are collected)

---

This change is 

[johnugeorge]

Will wait for review
/hold

[gaocegege]

/lgtm

[gaocegege]

We also need

diff --git a/pkg/controller/v1alpha2/trial/trial_controller_test.go b/pkg/controller/v1alpha2/trial/trial_controller_test.go
index dea2549f..f72e676e 100644
--- a/pkg/controller/v1alpha2/trial/trial_controller_test.go
+++ b/pkg/controller/v1alpha2/trial/trial_controller_test.go
@@ -143,6 +143,7 @@ func TestReconcileTFJobTrial(t *testing.T) {
        g.Expect(err).NotTo(gomega.HaveOccurred())
        defer c.Delete(context.TODO(), instance)
        g.Eventually(requests, timeout).Should(gomega.Receive(gomega.Equal(expectedRequest)))
+       g.Eventually(requests, timeout).Should(gomega.Receive(gomega.Equal(expectedRequest)))
 
        tfJob := &unstructured.Unstructured{}
        bufSize := 1024

[johnugeorge]

/hold cancel

[johnugeorge]

@gaocegege Shall we clean up requests in tests in a separate PR?

[gaocegege]

Ref #619

Yeah

[gaocegege]

/lgtm

[johnugeorge]

/cc @hougangliu
/cc @richardsliu
/cc @andreyvelich

[andreyvelich]

Yes, that should work for me.
Thank you @johnugeorge!
/lgtm

[richardsliu]

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [richardsliu]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment