Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a metrics collector proposal #732

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

wuchunghsuan
Copy link
Contributor

@wuchunghsuan wuchunghsuan commented Aug 29, 2019

What this PR does / why we need it:
Add a metrics collector proposal

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@wuchunghsuan
Copy link
Contributor Author

I made a mistake to close the previous PR.
/cc @gaocegege

@k8s-ci-robot k8s-ci-robot requested a review from gaocegege August 29, 2019 03:52
@gaocegege
Copy link
Member

@wuchunghsuan @hougangliu I think we could mark the proposal finished and merge it.

@wuchunghsuan wuchunghsuan changed the title [WIP] Add a metrics collector proposal Add a metrics collector proposal Sep 2, 2019
@gaocegege
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants