Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MetricsCollector pod injection for katib job #738

Merged
merged 2 commits into from
Sep 3, 2019
Merged

MetricsCollector pod injection for katib job #738

merged 2 commits into from
Sep 3, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Sep 3, 2019 •
edited
Loading

  1. support kubernetesJob pod metrics collector injection, not just Pytorch and tfjob worker kind
  2. Tfjob/pytorch job labels backward compatibility

This change is Reviewable

@hougangliu
Copy link
Member Author

/cc @gaocegege @wuchunghsuan @johnugeorge

gaocegege
gaocegege reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep both pod and job level webhooks?

@hougangliu
Copy link
Member Author

Can we keep both pod and job level webhooks?

sorry that my message misleads you, here I mean before this PR, we only support inject pod of pytorch and tfjob created by Katib, not including k8s Job worker kind. My PR fixes this gap

gaocegege
gaocegege reviewed Sep 3, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Gotcha, thanks.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gaocegege
gaocegege reviewed Sep 3, 2019
View reviewed changes
pkg/webhook/v1alpha2/pod/const.go
)

var JobRoleMap = map[string][]string{
"TFJob": {JobRoleLabel, TFJobRoleLabel},
Copy link
Member

@gaocegege gaocegege Sep 3, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could use Kind in tf-operator instead of a string. But here LGTM, too

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, we can do it. maybe another PR to cover all such replacement in katib

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@k8s-ci-robot k8s-ci-robot merged commit 7d8743c into kubeflow:master Sep 3, 2019
@johnugeorge johnugeorge mentioned this pull request Sep 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@jinan-zhou jinan-zhou Awaiting requested review from jinan-zhou

@garganubhav garganubhav Awaiting requested review from garganubhav

@johnugeorge johnugeorge Awaiting requested review from johnugeorge

@wuchunghsuan wuchunghsuan Awaiting requested review from wuchunghsuan

Assignees

@gaocegege gaocegege

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hougangliu @k8s-ci-robot @gaocegege