Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stdout of worker container show nothing #819

Merged
merged 1 commit into from
Sep 26, 2019
Merged

Fix stdout of worker container show nothing #819

merged 1 commit into from
Sep 26, 2019

Conversation

hougangliu
Copy link
Member

@hougangliu hougangliu commented Sep 26, 2019

Fixes: #810


This change is Reviewable

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@johnugeorge
Copy link
Member

Will tee command exist in all user images?/

@gaocegege
Copy link
Member

tee is a Linux command, I think it should be in all Linux distributions.

@hougangliu
Copy link
Member Author

hougangliu commented Sep 26, 2019

@johnugeorge based on https://en.wikipedia.org/wiki/List_of_Unix_commands, tee should exist in linux image, like cat, more, ls and so on

@johnugeorge
Copy link
Member

@hougangliu Thats the only concern that i had.

Looks good to me otherwise

@johnugeorge
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnugeorge

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

@gaocegege
Copy link
Member

/retest

@hougangliu
Copy link
Member Author

/test kubeflow-katib-presubmit

@k8s-ci-robot k8s-ci-robot merged commit e26c442 into kubeflow:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[enhancement] Show logs of trials using kubectl logs
4 participants