feat: support namespace for trial template #827
Conversation
|
/retest |
|
/assign @hougangliu @johnugeorge |
pkg/ui/v1alpha3/frontend/src/components/HP/Create/HPParameters.jsx
Outdated
Show resolved
Hide resolved
|
/hold |
|
Need to add an |
gaocegege
changed the title
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
|
|
/assign @johnugeorge @hougangliu |
| @@ -150,7 +151,10 @@ func (k *KatibClient) GetTrialTemplates(namespace ...string) (map[string]string, | |||
| ns := getNamespace(namespace...) | |||
| trialTemplates := &apiv1.ConfigMap{} | |||
|
|
|||
| if err := k.client.Get(context.Background(), types.NamespacedName{Name: experimentsv1alpha3.DefaultTrialConfigMapName, Namespace: ns}, trialTemplates); err != nil { | |||
| err := k.client.Get(context.TODO(), types.NamespacedName{Name: experimentsv1alpha3.DefaultTrialConfigMapName, Namespace: ns}, trialTemplates) | |||
There was a problem hiding this comment.
return k.GetConfigMap(experimentsv1alpha3.DefaultTrialConfigMapName, namespace)
BTW, now trialTemplate can be stored in any configmap, should we always get/update it in default ConfigMap?
There was a problem hiding this comment.
I can refactor it in another PR. Now #774 is in higher priority.
Signed-off-by: Ce Gao <gaoce@caicloud.io>
Signed-off-by: Ce Gao <gaoce@caicloud.io>
|
/cc @hougangliu Addressed the comments, PTAL |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hougangliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
|
/retest |
Signed-off-by: Ce Gao gaoce@caicloud.io
What this PR does / why we need it:
Add a namespace field for the template.
Release note:
This change is