Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reduce build time #84

Merged
merged 3 commits into from
May 15, 2018
Merged

Conversation

YujiOshima
Copy link
Contributor

Fix #50

Signed-off-by: YujiOshima yuji.oshima0x3fd@gmail.com

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@YujiOshima
Copy link
Contributor Author

/assign @gaocegege

@gaocegege

This comment has been minimized.

@gaocegege
Copy link
Member

Sorry, I misunderstand the script. The building time is reduced from 45 mins to 25 mins.

@YujiOshima
Copy link
Contributor Author

Though build time was reduced, is it still not enough? 🤔

@gaocegege
Copy link
Member

But it is still too long...

@gaocegege
Copy link
Member

Maybe we should parallel build the images as jose5918@ suggested.

Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
Signed-off-by: YujiOshima <yuji.oshima0x3fd@gmail.com>
@gaocegege

This comment has been minimized.

@YujiOshima
Copy link
Contributor Author

It looks to build parallelly. But it may replace Dockerfile before sending the code to gcloud...

@gaocegege
Copy link
Member

/LGTM

@gaocegege
Copy link
Member

I think we could separate the building process into different containers. For example. one is for manager and another is for CLI. Then we could run parallel building in container level. But the code LGTM since it works.

@gaocegege
Copy link
Member

/approve

@gaocegege gaocegege closed this May 15, 2018
@gaocegege gaocegege reopened this May 15, 2018
@gaocegege
Copy link
Member

/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f19f29b into kubeflow:master May 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants