Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support ppc64le #893

Merged
merged 3 commits into from
Nov 4, 2019
Merged

support ppc64le #893

merged 3 commits into from
Nov 4, 2019

Conversation

hmtai
Copy link
Contributor

@hmtai hmtai commented Oct 23, 2019

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #890

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:



This change is Reviewable

@hmtai
Copy link
Contributor Author

hmtai commented Oct 24, 2019

cc/ @hougangliu Please review.

@@ -6,7 +6,11 @@ RUN if [ "$(uname -m)" = "ppc64le" ]; then \
pip install cython; \
fi
RUN GRPC_HEALTH_PROBE_VERSION=v0.3.0 && \
wget -qO/bin/grpc_health_probe https://github.com/grpc-ecosystem/grpc-health-probe/releases/download/${GRPC_HEALTH_PROBE_VERSION}/grpc_health_probe-linux-amd64 && \
if [ "$(uname -m)" = "ppc64le" ]; then \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please handle all grpc_health_probe version under cmd/suggestion v1alpha3

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@hougangliu
Copy link
Member

@hmtai thanks
Please also update https://github.com/kubeflow/katib/blob/master/cmd/manager/v1alpha3/Dockerfile to use same version grpc_health_probe (follow suggestion way)

@hmtai
Copy link
Contributor Author

hmtai commented Oct 24, 2019

/retest

@k8s-ci-robot k8s-ci-robot removed the lgtm label Oct 24, 2019
@hougangliu
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hougangliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/retest

1 similar comment
@hmtai
Copy link
Contributor Author

hmtai commented Oct 25, 2019

/retest

@hougangliu
Copy link
Member

/retest

@gaocegege
Copy link
Member

@hmtai @hougangliu

This PR contains changes in suggestion image build. While now our test infra has some problems on pip install and cannot build the suggestion image successfully. Would you mind testing and merging it after 0.7?

@hougangliu
Copy link
Member

hougangliu commented Oct 28, 2019

@gaocegege sure. never mind

@hougangliu
Copy link
Member

/retest

1 similar comment
@hougangliu
Copy link
Member

/retest

@hougangliu
Copy link
Member

/retest

1 similar comment
@hougangliu
Copy link
Member

/retest

@jinchihe
Copy link
Member

jinchihe commented Nov 1, 2019

/test kubeflow-katib-presubmit

@hougangliu
Copy link
Member

@hmtai please rebase after #907 merged

@k8s-ci-robot k8s-ci-robot removed the lgtm label Nov 4, 2019
@gaocegege
Copy link
Member

Please rebase the master and let's see the CI result

@hougangliu
Copy link
Member

/lgtm

@hmtai
Copy link
Contributor Author

hmtai commented Nov 4, 2019

Please rebase the master and let's see the CI result

Yes,rebase it just now.

@k8s-ci-robot k8s-ci-robot merged commit c95c144 into kubeflow:master Nov 4, 2019
@hmtai hmtai deleted the hm branch November 4, 2019 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to build katib on ppc64le
5 participants