Remove katib webhook when undeploy #935
Conversation
|
/test kubeflow-katib-presubmit |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gaocegege The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/test kubeflow-katib-presubmit |
3 similar comments
|
/test kubeflow-katib-presubmit |
|
/test kubeflow-katib-presubmit |
|
/test kubeflow-katib-presubmit |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| @@ -22,6 +22,8 @@ set -o xtrace | |||
| SCRIPT_ROOT=$(dirname ${BASH_SOURCE})/../.. | |||
|
|
|||
| cd ${SCRIPT_ROOT} | |||
| kubectl get validatingwebhookconfigurations katib-validating-webhook-config && kubectl delete validatingwebhookconfigurations katib-validating-webhook-config | |||
| kubectl get mutatingwebhookconfigurations katib-mutating-webhook-config && kubectl delete mutatingwebhookconfigurations katib-mutating-webhook-config | |||
There was a problem hiding this comment.
Adding kubectl delete in deploy script is confusing. Why do we need this here?
There was a problem hiding this comment.
if there is same name webhook (when delete katib or kubeflow, webhook will not be deleted), controller won't recreate a new one. And the old one has configured with obsolete secret token, which will lead webhook call fail
There was a problem hiding this comment.
@hougangliu But I see that you have added the delete logic(webhook deletion) already in undeploy script. Am i mistaken here?
There was a problem hiding this comment.
yes, here is just a guard to make sure the obsolete webhook removed in case that there is katib webhooks existing before run deploy.sh (image that in a cluster 0.7.0 kubeflow installed, a user wants to run deploy.sh to update katib to latest)
|
/retest /hold for @johnugeorge 's question. I think it is used to ensure that we will recreate the webhook. |
|
/retest |
|
/test kubeflow-katib-presubmit |
1 similar comment
|
/test kubeflow-katib-presubmit |
|
/retest |
|
/hold cancel |
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Release note:
This change is