Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(README): Update instructions to only use kustomize #1455

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

Tomcli
Copy link
Member

@Tomcli Tomcli commented Feb 12, 2024

Which issue is resolved by this Pull Request:
Resolves #

Description of your changes:
Updating install instructions to use kubectl -k. kustomize is now a de facto part of kubectl and it make sense to let users install the manifests from it's true source rather than the release yaml we created. That way when master branch is cleaned up, users can still get the source file from each release tag.

Environment tested:

  • Python Version (use python --version):
  • Tekton Version (use tkn version):
  • Kubernetes Version (use kubectl version):
  • OS (e.g. from /etc/os-release):

Checklist:

@Tomcli Tomcli changed the title fix(REAME): Update instructions to only use kustomize fix(README): Update instructions to only use kustomize Feb 12, 2024
@Tomcli
Copy link
Member Author

Tomcli commented Feb 12, 2024

/assign @yhwang

Copy link
Member

@yhwang yhwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Feb 13, 2024
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Tomcli, yhwang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit a9d7df9 into master Feb 13, 2024
16 checks passed
@yhwang
Copy link
Member

yhwang commented Feb 13, 2024

this change reminds me that we don't need to run those GH actions if the content is doc/readme change only.

@Tomcli Tomcli deleted the Tomcli-patch-1 branch February 13, 2024 00:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants