fix make build; set IAM policy following read/modify/write

[kunmingg]

1. go binary need to import k8s 1.13.4 (kustomize) and 1.10.4 (ksonnet)
2. set IAM policy need to follow read/modify/write mode

---

This change is 

[kkasravi]

I would also change the Makefile from

build-bootstrap: generate fmt vet

to

build-bootstrap: /tmp/v2 deepcopy generate fmt vet

otherwise lgtm

[kkasravi]

/lgtm

[gabrielwen]

Reviewed 3 of 10 files at r1.
Reviewable status: 3 of 10 files reviewed, 3 unresolved discussions (waiting on @abhi-g, @ellis-bigelow, @gabrielwen, and @kunmingg)

---

bootstrap/cmd/bootstrap/app/gcpUtils.go, line 145 at r1 (raw file):

// Clear existing bindings for auto-generated service accounts of current deployment.
// Those bindings could be leftover from previous actions.
func ClearServiceAccountpolicy(currentPolicy *cloudresourcemanager.Policy, req ApplyIamRequest) {

nit: ClearServiceAccountPolicy

---

bootstrap/cmd/bootstrap/app/gcpUtils.go, line 147 at r1 (raw file):

func ClearServiceAccountpolicy(currentPolicy *cloudresourcemanager.Policy, req ApplyIamRequest) {
	serviceAccounts := map[string]bool{
		fmt.Sprintf("serviceAccount:%v-admin@%v.iam.gserviceaccount.com", req.Cluster, req.Project): true,

move this function to here and use it?

kubeflow/bootstrap/pkg/kfapp/gcp/gcp.go

Line 126 in b066e07

func getSA(name string, nameSuffix string, project string) string {

---

bootstrap/cmd/bootstrap/app/gcpUtils_test.go, line 45 at r1 (raw file):

					},
				},
				Etag: "NeedPreserve",

1. why adding this field?
2. could we use enum or consts instead of random appeared strings?

[kunmingg]

Reviewable status: 3 of 11 files reviewed, 2 unresolved discussions (waiting on @abhi-g, @ellis-bigelow, @gabrielwen, and @kunmingg)

---

bootstrap/cmd/bootstrap/app/gcpUtils.go, line 145 at r1 (raw file):

Previously, gabrielwen (Hung-Ting Wen) wrote…

nit: ClearServiceAccountPolicy

Done

---

bootstrap/cmd/bootstrap/app/gcpUtils.go, line 147 at r1 (raw file):

Previously, gabrielwen (Hung-Ting Wen) wrote…

move this function to here and use it?

kubeflow/bootstrap/pkg/kfapp/gcp/gcp.go

Line 126 in b066e07

func getSA(name string, nameSuffix string, project string) string {

Will do in followup RPs

---

bootstrap/cmd/bootstrap/app/gcpUtils_test.go, line 45 at r1 (raw file):

Previously, gabrielwen (Hung-Ting Wen) wrote…

1. why adding this field?
2. could we use enum or consts instead of random appeared strings?

Adding it to test to make sure we won't accidentally delete Etag.
Updated.

[kunmingg]

updated

[gabrielwen]

/lgtm

[kunmingg]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kunmingg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• bootstrap/OWNERS [kunmingg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment