Skip to content

Commit

Permalink
Disable init container injection for ray
Browse files Browse the repository at this point in the history
When istio is enabled, the kuberay-operator must disable the init
container injection.

See https://docs.ray.io/en/latest/cluster/kubernetes/k8s-ecosystem/istio.html#step-3-optional-enable-istio-mtls-strict-mode

Signed-off-by: Michael Fraenkel <929377+fraenkel@users.noreply.github.com>
  • Loading branch information
fraenkel authored and juliusvonkohout committed Dec 12, 2024
1 parent d676269 commit 3e4bcf7
Show file tree
Hide file tree
Showing 3 changed files with 18 additions and 2 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
apiVersion: apps/v1
kind: Deployment
metadata:
name: kuberay-operator
namespace: kubeflow
spec:
template:
spec:
containers:
- name: kuberay-operator
env:
- name: ENABLE_INIT_CONTAINER_INJECTION
value: "false"
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
namespace: kubeflow
resources:
- ../../base

patches:
- path: disable-injection.yaml
4 changes: 2 additions & 2 deletions contrib/ray/test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ kubectl label namespace $NAMESPACE istio-injection=enabled
kubectl get namespaces --selector=istio-injection=enabled

# Install KubeRay operator
kustomize build kuberay-operator/overlays/standalone | kubectl -n kubeflow apply --server-side -f -
kustomize build kuberay-operator/overlays/kubeflow | kubectl -n kubeflow apply --server-side -f -

# Wait for the operator to be ready.
kubectl -n kubeflow wait --for=condition=available --timeout=600s deploy/kuberay-operator
Expand Down Expand Up @@ -87,4 +87,4 @@ for ((i=0; i<TIMEOUT; i+=SLEEP_INTERVAL)); do
done

# Delete KubeRay operator
kustomize build kuberay-operator/base | kubectl -n kubeflow delete -f -
kustomize build kuberay-operator/base | kubectl -n kubeflow delete -f -

0 comments on commit 3e4bcf7

Please sign in to comment.