-
Notifications
You must be signed in to change notification settings - Fork 881
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update oidc-authservice #1714
Update oidc-authservice #1714
Conversation
Use the newer image of oidc-authservice, add mandatary parameter(AUTHSERVICE_URL_PREFIX) and change to `istio/base_v3`. Signed-off-by: Yihong Wang <yh.wang@ibm.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: yhwang The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @yhwang. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
/retest |
/test ? |
@PatrickXYS: The following commands are available to trigger jobs:
Use In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/test kubeflow-manifests-presubmit |
@yanniszark can you review this and see if it's good to pump up the oidc-authservice to the following:
Then it will enable the id-token authentication |
@yanniszark hope this could be included in v1.3. thanks! |
Will this be included for 1.3? |
I would love to include this, but doing so will break the logout button for CentralDashboard: In later versions, oidc-authservice changed the logout method to account for CSRF attacks: |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in one week if no further activity occurs. Thank you for your contributions. |
This issue has been closed due to inactivity. |
Fix for the logout button for Central Dashboard: kubeflow/kubeflow#6609 |
Use the newer image of oidc-authservice, add mandatary
parameter(AUTHSERVICE_URL_PREFIX) and change to
istio/base_v3
.Signed-off-by: Yihong Wang yh.wang@ibm.com
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Checklist:
cd manifests/tests
make generate-changed-only
make test