Adds profiles component

[swiftdiaries]

Link to ksonnet components this PR changes:
Profiles

Mapping ksonnet parameters to kustomize is kind of hard. For installing kubeflow to a custom namespace, with ksonnet we set an app level ks env with the namespace.

Kustomize does support a global namespace but it's unable to set it inside spec fields like in ambassador's deployment.

Opened an issue in kustomize for this: kubernetes-sigs/kustomize#854
I'm currently investigating how to add multiple parameters like we have in ksonnet to kubeflow manifests.

With respect to a ksonnet package having multiple prototypes, I'm currently treating them as separate manifests. See pytorch and pytorch-job in PR(#5)
This works well for pytorch-job because the only parameter is the image. And that can be set in straight-forward way using kustomize edit set image <image name> from inside the manifest folder.

/cc @jlewi @kkasravi

---

This change is 

[swiftdiaries]

/assign @kkasravi

[jlewi]

Marking this WIP because its blocked on other PRs. When the other PRs are merged and this one is updated remove WIP (this way I'll know its ready for another look).

[swiftdiaries]

/assign @jlewi
Ready for review.

[jlewi]

Can you please update the PR description to include the following

• Links to the ksonnet packages these are based on
• How you are mapping whatever customizability exists in the ksonnet package to the Kubeflow package?
  • In particular, does the ksonnet package have multiple parameters? If so how are they mapped to kustomize?
  • If there are multiple ksonnet prototypes how are these mapped to kustomize?

Also going forward it might be good to do a single package per PR.

[swiftdiaries]

Ok, that makes sense. Will update the PR with comments and split out future PRs into individual components.

[jlewi]

Thanks.

[kkasravi]

the image parameter (normally passed in ksonnet) isn't being set. Normally it would be
kustomize edit set image metacontroller/jsonnetd@sha256:25c25f217ad030a0f67e37078c33194785b494569b0c088d8df4f00da8fd15a0

I think it would be a good idea to note the parameters that ksonnet honors somewhere

[kkasravi]

maybe list parameters that are used from ksonnet here so it's easier to track

[kkasravi]

We should probably add a test framework - https://github.com/kubernetes-sigs/kustomize#a-great-report-is-a-bug-reproduction-test

[swiftdiaries]

Updated the PR comments. And added parameters from ksonnet to the README to track

[jlewi]

Sorry for the slow reply. Since this is one of the first kustomize package conversions I'd like to take a close look. I'm a bit swamped today but I will do my best to make time to look at it.

[swiftdiaries]

Ok sounds good! Thanks :)

…

On Wed, Mar 6, 2019 at 06:51 Jeremy Lewi ***@***.***> wrote: Sorry for the slow reply. Since this is one of the first kustomize package conversions I'd like to take a close look. I'm a bit swamped today but I will do my best to make time to look at it. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV9Rn4VZr9oRM31deUUeOX18ejbXXfWpks5vT9XrgaJpZM4bVc7o> .

[jlewi]

Reviewed 3 of 57 files at r1.
Reviewable status: 3 of 23 files reviewed, 10 unresolved discussions (waiting on @jlewi and @swiftdiaries)

---

README.md, line 14 at r5 (raw file):

kustomize build | kubectl apply -f

Bridging kustomize and ksonnet

Do we need to reference ksonnet in the README?

Eventually we will want to remove all references to ksonnet.

If you want to provide transition instructions maybe put them in a separate doc that we can just delete one we're done.

---

README.md, line 54 at r5 (raw file):

* Ambassador

### ksonnet parameters

Why are we referencing ksonnet here? Per above if if its information related to migration lets put in a separate doc.

---

README.md, line 63 at r5 (raw file):

      name: "ambassador",
      platform: "none",
      replicas: 3,

So for now if someone wanted to change the number of replicas would they have to either modify the base or use an overlay?

For the other parameters I don't think there's a strong need to easily expose them.

---

README.md, line 85 at r5 (raw file):

```json
jupyter: {

This is JupyterHub right? I think we can just remove all JupyterHub components because we won't be using it in 0.5

---

jupyter/base/jupyter-config-map.yaml, line 14 at r5 (raw file):

    Note that this file is also responsible for importing the UI-specific Spawner
    class from <ui-dir>/spawner.py, and setting the `spawner_class` configuration
    option.

Is this configmap only for JupyterHub?

If so then maybe we don't even need to add it or any other resources for JupyterHub
because with 0.5 we won't be deploying jupyterHub.

---

jupyter/base/jupyter-statefulset.yaml, line 2 at r5 (raw file):

apiVersion: apps/v1beta1
kind: StatefulSet

Per comment above; lets not add jupyterhub related components.

---

profiles/base/profiles-composite-controller-rbac.yaml, line 8 at r5 (raw file):

    name: profiles
    namespace: default
    server: https://35.203.186.20

Why is server specified here?

[jlewi]

We are likely moving away from Ambassador so i don't think its super critical to have a convenient way to set the namespace for Ambassador.

[swiftdiaries]

Ohh cool. I'll modify the README and add a separate doc for migration.
For number of replicas, the current usage is that you have an overlay defined for it.
For common edits/variants, I think it'll be better if we provide manifests and overlays OTB. Docs that point to how you use/set those variants.

Ok noted. Will remove all references to JupyterHub.

[jlewi]

@swiftdiaries Thanks is this ready for another look or are you still working on it?

[swiftdiaries]

I’m still working on this. Ill get some commits in the evening.

…

On Fri, Mar 8, 2019 at 10:42 Jeremy Lewi ***@***.***> wrote: @swiftdiaries <https://github.com/swiftdiaries> Thanks is this ready for another look or are you still working on it? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#2 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AV9Rny1bBTUYZRCksyzPhdsGVh7ITHo0ks5vUq8DgaJpZM4bVc7o> .

[swiftdiaries]

@jlewi This is ready for another look.
I'm currently referencing the profiles controller kustomization from within my fork. Once kubeflow/kubeflow#2692 merges, I can replace it in the next commit.

[jlewi]

/lgtm
/approve
Please file an issue to fix the reference to the kustomize package.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jlewi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment