common: Upgrade Knative Serving manifests to version 1.8.1 #2335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
* Update instructions
- No need to explicitly change the `portLevelMtls.8443` keys
to be string as this is fixed in upstream
(knative-extensions/net-istio#841)
* Update version references of knative-serving
Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
|
@apo-ger looks good! I also run the e2e script manually and it succeeded https://github.com/kubeflow/manifests/tree/master/tests/e2e. Although we'll need to extend it to also make a request to the ISVC to ensure the networking is working properly. /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: apo-ger, kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kevin85421
pushed a commit
to juliusvonkohout/manifests
that referenced
this pull request
Feb 28, 2023
…2335) * common: Upgrade knative-serving manifests to v1.8.1 Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> * Update README files * Update instructions - No need to explicitly change the `portLevelMtls.8443` keys to be string as this is fixed in upstream (knative-extensions/net-istio#841) * Update version references of knative-serving Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com> Signed-off-by: Apostolos Gerakaris <apoger@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
READMEfiles (version references, instructions etc)Refs: #2325