-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for dco changes #2713
Fixes for dco changes #2713
Conversation
* Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Afterwards we can adjust and merge #2712 for the 1.9.0-rc1 release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mmmm maybe because of this 03f7877 where there were two commits that have been squashed ending up in multiple signed-off by
lines? (just guessing).
/lgtm
/approve
/lgtm |
@juliusvonkohout your signoffs use a weird email (probably the GitHub user ID email). Is this intended? |
Yes, i do not want more spam :-D |
DCO tests are passing. Lets hope the master branch will be happy as well. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout, lampajr The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
It seems not 🫤 |
Nevermind, now it is green! 🎉 |
* Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * update readme (#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Fixes for dco changes (#2713) * Fix kserve upgrade script and update kserve diagram (#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update cert-manager to 1.14.5 (#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Refactor test workflows (#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme (#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade knative to v1.12.4 (#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Fixes for dco changes (kubeflow#2713) * Fix kserve upgrade script and update kserve diagram (kubeflow#2702) * Fix kserve upgrade script and update kserve diagram Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> * Update Readme Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update cert-manager to 1.14.5 (kubeflow#2703) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704) * Upgrade bentoml to 1.2.28 and 1.1.21 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Bentoml skip broken curl in kind test Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Refactor test workflows (kubeflow#2693) * Renamed workflow files * Fixed dependency files * Upgrade actions/checkout to v4 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme (kubeflow#2707) Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade dex to 2.39.1 (kubeflow#2710) Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Upgrade knative to v1.12.4 (kubeflow#2709) * Add common/knative sync script Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> * Update common/knative manifests from v1.12.4/v1.12.6 Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com> --------- Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com> Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com> Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com> Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
@lampajr something in your commits confused the DCO later on or the DCO checks were changed. Probably the latter. I signed them off again. See https://github.com/kubeflow/manifests/runs/24884888875
Plaese check and
/lgtm