Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for dco changes #2713

Merged
merged 7 commits into from
May 13, 2024
Merged

Fixes for dco changes #2713

merged 7 commits into from
May 13, 2024

Conversation

juliusvonkohout
Copy link
Member

@juliusvonkohout juliusvonkohout commented May 13, 2024

@lampajr something in your commits confused the DCO later on or the DCO checks were changed. Probably the latter. I signed them off again. See https://github.com/kubeflow/manifests/runs/24884888875

Plaese check and

/lgtm

sivanantha321 and others added 7 commits May 13, 2024 09:17
* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
@juliusvonkohout
Copy link
Member Author

Afterwards we can adjust and merge #2712 for the 1.9.0-rc1 release.

Copy link
Member

@lampajr lampajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmmm maybe because of this 03f7877 where there were two commits that have been squashed ending up in multiple signed-off by lines? (just guessing).

/lgtm
/approve

@lampajr
Copy link
Member

lampajr commented May 13, 2024

/lgtm

@StefanoFioravanzo
Copy link
Member

@juliusvonkohout your signoffs use a weird email (probably the GitHub user ID email). Is this intended?

@juliusvonkohout
Copy link
Member Author

@juliusvonkohout your signoffs use a weird email (probably the GitHub user ID email). Is this intended?

Yes, i do not want more spam :-D

@juliusvonkohout
Copy link
Member Author

DCO tests are passing. Lets hope the master branch will be happy as well.

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, lampajr

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 4547b2f into master May 13, 2024
26 checks passed
@lampajr
Copy link
Member

lampajr commented May 13, 2024

DCO tests are passing. Lets hope the master branch will be happy as well.

It seems not 🫤

@lampajr
Copy link
Member

lampajr commented May 13, 2024

DCO tests are passing. Lets hope the master branch will be happy as well.

It seems not 🫤

Nevermind, now it is green! 🎉

google-oss-prow bot pushed a commit that referenced this pull request May 13, 2024
* Fix kserve upgrade script and update kserve diagram (#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* update cert-manager to 1.14.5 (#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Refactor test workflows  (#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* update readme (#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Upgrade knative to v1.12.4 (#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Fixes for dco changes (#2713)

* Fix kserve upgrade script and update kserve diagram (#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update cert-manager to 1.14.5 (#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Refactor test workflows  (#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme (#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade knative to v1.12.4 (#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
@juliusvonkohout juliusvonkohout deleted the fixes-for-dco-changes branch May 16, 2024 12:38
doncorsean pushed a commit to doncorsean/kubeflow-manifests that referenced this pull request Jul 18, 2024
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update cert-manager to 1.14.5 (kubeflow#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Refactor test workflows  (kubeflow#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme (kubeflow#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (kubeflow#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade knative to v1.12.4 (kubeflow#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
rimolive pushed a commit to rimolive/manifests that referenced this pull request Aug 19, 2024
* Fix kserve upgrade script and update kserve diagram (kubeflow#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* update cert-manager to 1.14.5 (kubeflow#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Refactor test workflows  (kubeflow#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* update readme (kubeflow#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (kubeflow#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Upgrade knative to v1.12.4 (kubeflow#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Fixes for dco changes (kubeflow#2713)

* Fix kserve upgrade script and update kserve diagram (kubeflow#2702)

* Fix kserve upgrade script and update kserve diagram

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

* Update Readme

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update cert-manager to 1.14.5 (kubeflow#2703)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade bentoml to 1.2.28 and 1.1.21 (kubeflow#2704)

* Upgrade bentoml to 1.2.28 and 1.1.21

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Bentoml skip broken curl in kind test

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Refactor test workflows  (kubeflow#2693)

* Renamed workflow files
* Fixed dependency files
* Upgrade actions/checkout to v4

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme (kubeflow#2707)

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade dex to 2.39.1 (kubeflow#2710)

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Upgrade knative to v1.12.4 (kubeflow#2709)

* Add common/knative sync script

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

* Update common/knative manifests from v1.12.4/v1.12.6

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>

---------

Signed-off-by: Sivanantham Chinnaiyan <sivanantham.chinnaiyan@ideas2it.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Co-authored-by: Sivanantham <90966311+sivanantha321@users.noreply.github.com>
Co-authored-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants