-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PSS to contrib/baseline and contrib/restricted as kustomize components #2757
Conversation
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
I would be pushing more commits and still open to suggestions mid-way. |
kind: Component | ||
|
||
resources: | ||
- ../../../../../common/kubeflow-namespace/base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two resources here are already in example.yaml. Why do you list them here as well?
You should add this component here commented out to example.yaml instead as planned in the Google document.
|
||
resources: | ||
- ../../../../../common/kubeflow-namespace/base | ||
- ../../../../../common/istio-1-22/istio-namespace/base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two resources here are already in example.yaml. Why do you list them here as well?
You should add this component here commented out to example.yaml instead as planned in the Google document.
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
example/kustomization.yaml
Outdated
@@ -88,3 +88,9 @@ resources: | |||
# KServe | |||
- ../contrib/kserve/kserve | |||
- ../contrib/kserve/models-web-app/overlays/kubeflow | |||
|
|||
#Pod Security Standarards enabled |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check the spelling
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Should be have PSS for other namespaces like auth, cert-manager, etc? |
example/kustomization.yaml
Outdated
@@ -89,7 +89,7 @@ resources: | |||
- ../contrib/kserve/kserve | |||
- ../contrib/kserve/models-web-app/overlays/kubeflow | |||
|
|||
#Pod Security Standarards enabled | |||
#Pod Security Standards |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets maybe link to the documentation in the comment https://kubernetes.io/docs/concepts/security/pod-security-standards/ and check that you match the style and indenting of the other parts in the document.
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
Signed-off-by: biswajit-9776 <biswajitpatt139@gmail.com>
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Pull Request Template for Kubeflow manifests Issues
✏️ A brief description of the changes
📦 List any dependencies that are required for this change
🐛 If this PR is related to an issue, please put the link of the issue here.
✅ Unit Test Checklist
✅ Contributor checklist
DCO
check)cla/google
check)