Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[frontend] Upgrade Argo UI template to match original content #5358

Closed
zijianjoy opened this issue Mar 22, 2021 · 0 comments · Fixed by #5359
Closed

[frontend] Upgrade Argo UI template to match original content #5358

zijianjoy opened this issue Mar 22, 2021 · 0 comments · Fixed by #5359
Assignees
@zijianjoy
Labels
area/frontend kind/process

Comments

@zijianjoy
Copy link
Collaborator

We have upgraded backend to use newer Argo version 2.12.9:#5266. Based on #5339 (comment), we need to make sure we are also updating other contents in /kubeflow/pipelines/frontend/third_party/argo-ui/argo_template.ts to match https://github.com/argoproj/argo-workflows/blob/80b5ab9b8e35b4dba71396062abe32918cd76ddd/ui/src/models/workflows.ts#L863-L873.
@zijianjoy zijianjoy self-assigned this Mar 22, 2021
@zijianjoy zijianjoy linked a pull request Mar 22, 2021 that will close this issue
feat(frontend): Upgrade argo template on UI. Fix #5358 #5359
Merged
2 tasks
google-oss-robot pushed a commit that referenced this issue Mar 29, 2021
@zijianjoy
feat(frontend): Upgrade argo template on UI. Fix #5358 (#5359)
a9f8eec 
* Upgrade argo template

* address comments and apply argo ui 1.12.10

* use argo NODE_PHASE

* Copy from argo v2.12.9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zijianjoy zijianjoy

Labels
area/frontend kind/process
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(frontend): Upgrade argo template on UI. Fix #5358 zijianjoy/pipelines
2 participants
@hilcj @zijianjoy