Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KFP should support containerd runtime on Kube #678

Closed
animeshsingh opened this issue Jan 14, 2019 · 10 comments
Closed

KFP should support containerd runtime on Kube #678

animeshsingh opened this issue Jan 14, 2019 · 10 comments
Assignees
@IronPan @animeshsingh
Labels
area/backend area/components area/docs help wanted The community is welcome to contribute. kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p1

Comments

@animeshsingh
Copy link
Contributor

KubeFlow pipeline currently only works on Docker runtime since the pipeline output artifacts are copied with "docker cp" command. We need support for containerd runtime
@animeshsingh animeshsingh changed the title KFP should support containerd runtimes on Kube KFP should support containerd runtime on Kube Jan 14, 2019
@hongye-sun
Copy link
Contributor

Could you give more context on why it's needed?

We rely on argo to copy the artifact files. However, only docker executor currently supports file operations in argo (https://github.com/argoproj/argo/tree/master/workflow/executor). There is an argo FR to get rid of docker cp and it seems that argo team had a plan but still WIP.

@animeshsingh
Copy link
Contributor Author

animeshsingh commented Jan 18, 2019 •
edited
Loading

@hongye-sun we are moving towards containerd in IBM Cloud IKS, and hence this becomes key
https://www.ibm.com/blogs/bluemix/2019/01/ibm-cloud-kubernetes-service-supports-containerd/

@animeshsingh
Copy link
Contributor Author

Hi folks - coming back to this. Given we have phased out support for docker in IBM Kubernetes service, this is becoming a blocker. Anyway to take this forward jointly with Argo?

@animeshsingh animeshsingh mentioned this issue Feb 26, 2019
Closed
@vicaire
Copy link
Contributor

vicaire commented Mar 8, 2019

Thanks for filing the issue with Argo. Would you be able to drive support for containerd with both Argo and then KFP? Let me know if some help is needed.

@animeshsingh
Copy link
Contributor Author

Thanks @vicaire. Definitely chasing it - there is a PR with Argo which are trying to make it work within our context, and then will be going back with what still remains opens.

@vicaire vicaire added help wanted The community is welcome to contribute. priority/p1 area/components kind/feature labels Mar 26, 2019
@Duske
Copy link

Duske commented Jun 10, 2019

Hey @animeshsingh, with new process namespace sharing (PNS) I got argo to run with containerd on k3s, no docker involved. You can use it by setting a property in the config map as described in #901 here

Does this solve your problem?

@MingzhouZhou
Copy link

MingzhouZhou commented Jan 17, 2020 •
edited
Loading

For those who have the same issue, add or change containerRuntimeExecutor: k8sapi, to configmap workflow-controller-configmap and restart deployment ml-pipeline work for pipeline version 0.1.39, and this has been fixed in argo: argoproj/argo-workflows#1419

@stale
Copy link

stale bot commented Jun 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the lifecycle/stale The issue / pull request is stale, any activities remove this label. label Jun 24, 2020
@stale
Copy link

stale bot commented Jul 2, 2020

This issue has been automatically closed because it has not had recent activity. Please comment "/reopen" to reopen it.

@stale stale bot closed this as completed Jul 2, 2020
@susan-shu-c
Copy link
Contributor

Does this work without needing to modify Argo?

Linchin pushed a commit to Linchin/pipelines that referenced this issue Apr 11, 2023
@jlewi
Initial batch of fixes to run E2E notebook tests against blueprint de…
b0fc709 
…ployments. (kubeflow#678)

* Update get_kf_testing_cluster to work with blueprints
  * With GCP blueprints we won't have deployments so we need to
    list clusters by name and find cluster with matching regex.

* Create an ACM repo for kf-ci-v1 cluster and hydrate it with the appropriate
  manifests for the auto-deploy and tektoncd namespaces.

  * kubeflow/testing#677 is tracking using ACM with the cluster kf-ci-v1
  * Note this PR is only using ACM to sync tekton resources; we still need
    to sync the rest of the auto-deployment infrastructure like the reconciler
    and webserver.

  * Remove ACM cluster selector; ACM complains because it isn't actually being applied.

* Override notebook-test-task.yaml with nb-test-task.yaml. The latter should include the latest changes from Gabriel's PR.

* When deploying the blueprint we need to do `kpt cfg set email` to
  set the email for the default profile. Without this change
  the deployment won't include the namespace we need to run
  the tests in

GoogleCloudPlatform/kubeflow-distribution#42 is tracking CI for the blueprints.
magdalenakuhn17 pushed a commit to magdalenakuhn17/pipelines that referenced this issue Oct 22, 2023
@rzgry
Add custom image sample documentation (kubeflow#678)
e4ed2c6 
* Add documentation for custom sample

* Add TARGET env var

* Add requirements.txt and update README

* kfservingsdk example

* Add expected output

* Update model name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@IronPan IronPan

@animeshsingh animeshsingh

Labels
area/backend area/components area/docs help wanted The community is welcome to contribute. kind/feature lifecycle/stale The issue / pull request is stale, any activities remove this label. priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@Ark-kun @IronPan @animeshsingh @Duske @MingzhouZhou @susan-shu-c @vicaire @hongye-sun