Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ui): request task logs only if pod was created #11458

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ntny
Copy link
Contributor

@ntny ntny commented Dec 11, 2024

Description of your changes:

Request the task logs only if the pod was created and the pod name is available.

Scenario: a new task in run is about to start

  1. Execution record in mlmd was created with a status of Running (in the -system-container-driver- Pod)
  2. -system-container-impl- pod has not yet been started and Launcher has not yet saved the pod name into the MLMD execution
  3. At this point, the Run Details/Logs tab starts pulling logs and may request them before the pod name is available, leading to an error (see attached), which could confuse the user

This issue is resolved by not requesting the log if the pod name is still unavailable. Instead of the error, the user will see an empty console until the pod is created
Снимок экрана 2024-12-11 в 22 34 55

Copy link

Hi @ntny. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign zijianjoy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Signed-off-by: arpechenin <arpechenin@avito.ru>
@ntny ntny force-pushed the retrieve-task-logs-only-after-pod-was-created branch from d429840 to aa6f5cd Compare December 11, 2024 20:11
Copy link
Contributor

@hbelmiro hbelmiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/ok-to-test

@hbelmiro
Copy link
Contributor

cc @HumairAK

Copy link
Contributor

@DharmitD DharmitD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants