-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Updated Argo to v2.4.1 #2419
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@Ark-kun I think you need to use my scripts here: #2393 to regenerate license.txt with this new version of argo and manually maintain repo-MPL.txt. Also, the tag name |
163c9df
to
484c759
Compare
484c759
to
0de3d18
Compare
/test kubeflow-pipeline-e2e-test |
2 similar comments
/test kubeflow-pipeline-e2e-test |
/test kubeflow-pipeline-e2e-test |
@Ark-kun do you mind sharing more context why we need to bump the version in the description? are we relying on workflow template now? |
We're not relying on it. But Argo controller failed to start because WorkflowTemplate was missing/denied somewhere. |
Here is the error I was getting: |
@Ark-kun: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@Ark-kun Seems most of the users are looking for 2.5.0 and above. Is there a chance we bump to that version or latest Argo directly? |
I've already upgraded Argo to v2.7.5 |
This change is