Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updated Argo to v2.4.1 #2419

Closed
wants to merge 5 commits into from

Conversation

Ark-kun
Copy link
Contributor

@Ark-kun Ark-kun commented Oct 17, 2019

This change is Reviewable

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign neuromage
You can assign the PR to them by writing /assign @neuromage in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Bobgy
Copy link
Contributor

Bobgy commented Oct 17, 2019

@Ark-kun I think you need to use my scripts here: #2393 to regenerate license.txt with this new version of argo and manually maintain repo-MPL.txt.

Also, the tag name v2.3.0-license-compliance was only meant to differentiate with existing gcr.io/ml-pipeline/argoexec:v2.3.0. Since we never tagged gcr.io/ml-pipeline/argoexec:v2.4.1 before, I recommend switching back to just use the same tag as argo images.

@Ark-kun Ark-kun force-pushed the Updated-Argo-to-v2.4.1 branch from 163c9df to 484c759 Compare October 17, 2019 02:21
@Ark-kun Ark-kun force-pushed the Updated-Argo-to-v2.4.1 branch from 484c759 to 0de3d18 Compare October 17, 2019 02:22
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 18, 2019

/test kubeflow-pipeline-e2e-test

2 similar comments
@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 18, 2019

/test kubeflow-pipeline-e2e-test

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 18, 2019

/test kubeflow-pipeline-e2e-test

@IronPan
Copy link
Member

IronPan commented Oct 25, 2019

@Ark-kun do you mind sharing more context why we need to bump the version in the description? are we relying on workflow template now?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Oct 27, 2019

@Ark-kun do you mind sharing more context why we need to bump the version in the description? are we relying on workflow template now?

We're not relying on it. But Argo controller failed to start because WorkflowTemplate was missing/denied somewhere.
We can probably add it to fewer places, but it needs to be investigated.

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Nov 2, 2019

Here is the error I was getting:
github.com/argoproj/argo/workflow/controller/controller.go:157: Failed to list *v1alpha1.WorkflowTemplate: workflowtemplates.argoproj.io is forbidden: User "system:serviceaccount:kubeflow:argo" cannot list resource "workflowtemplates" in API group "argoproj.io" in the namespace "kubeflow"

@k8s-ci-robot
Copy link
Contributor

@Ark-kun: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
kubeflow-pipeline-upgrade-test 2a5e9ee link /test kubeflow-pipeline-upgrade-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ark-kun Ark-kun mentioned this pull request Mar 23, 2020
@Jeffwan
Copy link
Member

Jeffwan commented Apr 18, 2020

@Ark-kun Seems most of the users are looking for 2.5.0 and above. Is there a chance we bump to that version or latest Argo directly?

@Ark-kun
Copy link
Contributor Author

Ark-kun commented Jun 23, 2020

I've already upgraded Argo to v2.7.5

@Ark-kun Ark-kun closed this Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants