Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP:v2-poc-fix #5108

Closed
wants to merge 2 commits into from
Closed

WIP:v2-poc-fix #5108

wants to merge 2 commits into from

Conversation

capri-xiyue
Copy link
Contributor

  • add kfp v2 hello world sample
  • generate go proto code
  • code to unmarshal via jsonpb
  • generate container spec
  • add root DAG task and Makefile to run in argo
  • env setup to quickly build driver container
  • generate mlmd grpc golang client
  • mlmd grpc client usage example
  • driver-dag: put execution and context
  • driver dag: put context only when execution is a DAG
  • driver task: resolve parameter from parent execution
  • chain dag driver with task driver
  • driver: output argo parameters
  • driver: build driver docker image
  • driver: push image to dev registry
  • compiler: root dag driver compiler
  • mlmd doc
  • driver: use task spec and executor spec as driver input instead
  • driver: pod spec patch output for type EXECUTOR
  • compiler: passing - parameter placeholder with hello world example
  • include generated argo workflow in source control
  • driver no longer outputs parameters
  • publisher: publish parameters to execution custom properties
  • driver, publisher: execution state
  • publisher: remove built binary from repo
  • sample: add producer consumer sample
  • sample: producer consumer sample with only parameters
  • e2e output parameter support
  • e2e: driver resolves input parameter from tasks in the same DAG
  • compiler: convert KFP task dependency to argo task dependency
  • feat: refactor publisher so it can run as an entrypoint
  • build: entrypoint image
  • feat: executor and publisher in one container via entrypoint rewriting

Description of your changes:

Checklist:

@Bobgy
Changes:
5c27758 
* add kfp v2 hello world sample
* generate go proto code
* code to unmarshal via jsonpb
* generate container spec
* add root DAG task and Makefile to run in argo
* env setup to quickly build driver container
* generate mlmd grpc golang client
* mlmd grpc client usage example
* driver-dag: put execution and context
* driver dag: put context only when execution is a DAG
* driver task: resolve parameter from parent execution
* chain dag driver with task driver
* driver: output argo parameters
* driver: build driver docker image
* driver: push image to dev registry
* compiler: root dag driver compiler
* mlmd doc
* driver: use task spec and executor spec as driver input instead
* driver: pod spec patch output for type EXECUTOR
* compiler: passing - parameter placeholder with hello world example
* include generated argo workflow in source control
* driver no longer outputs parameters
* publisher: publish parameters to execution custom properties
* driver, publisher: execution state
* publisher: remove built binary from repo
* sample: add producer consumer sample
* sample: producer consumer sample with only parameters
* e2e output parameter support
* e2e: driver resolves input parameter from tasks in the same DAG
* compiler: convert KFP task dependency to argo task dependency
* feat: refactor publisher so it can run as an entrypoint
* build: entrypoint image
* feat: executor and publisher in one container via entrypoint rewriting
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: capri-xiyue
To complete the pull request process, please assign ironpan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: capri-xiyue
To complete the pull request process, please assign ironpan after the PR has been reviewed.
You can assign the PR to them by writing /assign @ironpan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested review from Ark-kun and Bobgy February 5, 2021 20:28
@google-cla google-cla bot added the cla: yes label Feb 5, 2021
@capri-xiyue
Copy link
Contributor Author

/test kubeflow-pipeline-backend-test

@capri-xiyue capri-xiyue mentioned this pull request Feb 5, 2021
Merged
2 tasks
@capri-xiyue capri-xiyue changed the title <WIP>v2-poc-fix WIP:v2-poc-fix Feb 5, 2021
@capri-xiyue
Copy link
Contributor Author

This PR is just to test the fix of #5092 works.
After Bobgy#1 got merged into #5092 and the tests of #5092 passed, we can close this PR.

@capri-xiyue
Copy link
Contributor Author

closed （in favor of #5092）

@capri-xiyue capri-xiyue closed this Feb 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ark-kun Ark-kun Awaiting requested review from Ark-kun

@Bobgy Bobgy Awaiting requested review from Bobgy

@chensun chensun Awaiting requested review from chensun

@dushyanthsc dushyanthsc Awaiting requested review from dushyanthsc

@numerology numerology Awaiting requested review from numerology

Assignees
No one assigned
Labels
cla: yes do-not-merge/work-in-progress size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@capri-xiyue @k8s-ci-robot @google-oss-robot @Bobgy