-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sdk): Surface kubernetes configuration in container builder #6095
feat(sdk): Surface kubernetes configuration in container builder #6095
Conversation
Hi @casassg. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
f124066
to
6647d36
Compare
/assign @ji-yaqi Assigning as PR is pretty small (lmk whats the acceptable process for this in the future pls) |
rebumping this up! |
@chensun any chance to check this one? Im happy to close if deemed not appropriate |
/ok-to-test |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description of your changes:
Python Kubernetes SDK doesn't handle well tokens that expire. GCP default authentication has set its own custom refresh token, but for other kubernetes API authentication mechanisms it's not trivial to implement.
In order to customize authentication, users of the python sdk can customize the client configuration object to set a custom
refresh_api_key_hook
and provide it toload_kube_config
.With this change, in ContainerBuilder, we can inject a custom client configuration that will be used by the client to check the kaniko execution.
I avoided setting it for
load_incluster_config
as usually that uses the internal token provider in the cluster and therefore has less need to be customized. To avoid confusion, I can name itkubernetes_outcluster_configuration
?Related issues: kubernetes-client/python#741