Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk.v2): Add HTML and Markdown artifact types #6246

Merged
merged 2 commits into from
Aug 6, 2021
Merged

feat(sdk.v2): Add HTML and Markdown artifact types #6246

merged 2 commits into from
Aug 6, 2021

Conversation

chensun
Copy link
Member

@chensun chensun commented Aug 5, 2021 •
edited by zijianjoy
Loading

Description of your changes:
Reference: #3970, #5798

Checklist:

@google-cla google-cla bot added the cla: yes label Aug 5, 2021
@chensun chensun mentioned this pull request Aug 5, 2021
Merged
@chensun chensun requested review from zijianjoy and removed request for Ark-kun August 5, 2021 21:59
@chensun
Copy link
Member Author

chensun commented Aug 6, 2021

/retest

@Bobgy
Copy link
Contributor

Bobgy commented Aug 6, 2021

/lgtm
thanks for adding the new types that will unblock @zijianjoy 's work

@Bobgy
Copy link
Contributor

Bobgy commented Aug 6, 2021

@zijianjoy can you link the PR to be part of the tracking issue

zijianjoy
zijianjoy reviewed Aug 6, 2021
View reviewed changes
sdk/python/kfp/v2/compiler_cli_tests/test_data/pipeline_with_various_io_types.py
@@ -60,6 +62,7 @@
- {name: input_e, type: Datasets}
- {name: input_f, type: Some arbitrary type}
- {name: input_g, type: {GcsPath: {data_type: TSV}}}
- {name: input_h, type: HTML}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also add the Markdown type input here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not necessarily need to capture all the types we have in this test.
But type_utils_test.py has UTs for the complete list of artifact types.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, thanks Chen for confirming!

@zijianjoy
Copy link
Collaborator

Thank you @chensun for making the PR!

Good point @Bobgy , I have added the associated issues in this PR's description.

@chensun
Copy link
Member Author

chensun commented Aug 6, 2021

/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chensun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit f4657ba into kubeflow:master Aug 6, 2021
@chensun chensun deleted the html-markdown branch August 6, 2021 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zijianjoy zijianjoy zijianjoy left review comments

@ji-yaqi ji-yaqi Awaiting requested review from ji-yaqi

Assignees

@Bobgy Bobgy

@ji-yaqi ji-yaqi

Labels
approved cla: yes lgtm size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chensun @Bobgy @zijianjoy @google-oss-robot @ji-yaqi