Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade tfx to 1.0.0 #6316

Merged
merged 4 commits into from
Aug 12, 2021
Merged

Conversation

jiyongjung0
Copy link
Contributor

Description of your changes:
Part of #6311. Branched from #6312 by @Bobgy

Checklist:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@google-oss-robot
Copy link

Hi @jiyongjung0. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jiyongjung0
Copy link
Contributor Author

@Bobgy I created this on top of your cl (#6312) Please take a look. Thanks!!

@Bobgy
Copy link
Contributor

Bobgy commented Aug 12, 2021

/ok-to-test

@Bobgy
Copy link
Contributor

Bobgy commented Aug 12, 2021

Super, I think this looks perfect!

@Bobgy
Copy link
Contributor

Bobgy commented Aug 12, 2021

/lgtm
/Approve
As long as the tests are passing, we can merge

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit a1f7160 into kubeflow:master Aug 12, 2021
@Bobgy Bobgy mentioned this pull request Aug 12, 2021
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants