Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update visualization v2 to output HTML and Markdown. Partial #3970 #6349

Merged
merged 5 commits into from
Aug 17, 2021

Conversation

zijianjoy
Copy link
Collaborator

Description of your changes:
Partial #3970

outputhtml
outputmd

Checklist:

Copy link
Contributor

@Bobgy Bobgy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

samples/test/metrics_visualization_v2_test.py Show resolved Hide resolved
@zijianjoy zijianjoy requested review from chensun and Bobgy August 16, 2021 06:11
@Bobgy
Copy link
Contributor

Bobgy commented Aug 16, 2021

FYI, I'm fixing e2e tests in #6351

@Bobgy
Copy link
Contributor

Bobgy commented Aug 17, 2021

/lgtm
/approve

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Bobgy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-robot google-oss-robot merged commit 5203ecf into kubeflow:master Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants