-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): update minio-go to support irsa #7946
Conversation
Hi @ryansteakley. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@chensun can you take a look here? This pr was mentioned by @surajkota during kf meetings |
/assign @chensun |
/ok-to-test |
@chensun Can you please take a look. |
I recall one open question we had in the meeting is to research whether the latest Minio client works with older Minio server, as we can't upgrade the server due to license issue. I assume you did the research? Can you please add that in the PR description, with references if possible? Thanks! |
@chensun have included some context etc, if you require screenshots of all the pods in a running state or examples of pipeline jobs successfully running I can supply those as well |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chensun thanks for the prompt review. Is it possible for this to be included in the pipeline release that goes into kubeflow manifests 1.6? |
Yes, we're planning for another release, hopefully by tomorrow, to be pair with kubeflow 1.6. |
Description of your changes:
Have used docker to create an image with these changes and deployed them on a fresh eks cluster. Everything worked as expected with existing behavior and usage of minio i.e(using static aws credentials). Successfully ran the sample pipelines included and verified upload of data.
Additionally the minio-go changes that included support for IRSA which were included in minio-go version v6.0.53 and up are already included and part of the base minio version which we are using so we will not need to update it and thus will not face licensing issues. Minio included the support for it https://github.com/minio/minio/tree/RELEASE.2019-03-06T22-47-10Z while we are using a later version 2019-08-14T20-37-41Z
Checklist: