Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update executor status if pod is lost while app is still running #1111

Merged
merged 1 commit into from
Dec 10, 2020

Conversation

ImpSy
Copy link
Contributor

@ImpSy ImpSy commented Dec 10, 2020

Hello,

This PR is related to issue #1076

Following the discussion on this issue, it seems that we can change the status of lost pods to unknown while the app is still running
Then once the driver pod is terminated, we fall back to the current implementation

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@liyinan926 liyinan926 merged commit a60896f into kubeflow:master Dec 10, 2020
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants