Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue #1131 #1142

Merged
merged 4 commits into from
Feb 5, 2021
Merged

fix issue #1131 #1142

merged 4 commits into from
Feb 5, 2021

Conversation

kz33
Copy link
Contributor

@kz33 kz33 commented Jan 26, 2021

Fixing issue:#1131

@google-cla
Copy link

google-cla bot commented Jan 26, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@kz33
Copy link
Contributor Author

kz33 commented Jan 26, 2021

@googlebot I signed it!

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also update README.md for the new config option.

charts/spark-operator-chart/values.yaml Outdated Show resolved Hide resolved
@liyinan926
Copy link
Collaborator

Please update the chart version.

@kz33
Copy link
Contributor Author

kz33 commented Feb 1, 2021

Hi @liyinan926
Can you help me see the reason why CI hasn't passed it? Thanks so much !

@liyinan926
Copy link
Collaborator

Can you do some dummy commit to trigger the Travis build?

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liyinan926 liyinan926 merged commit 4f50304 into kubeflow:master Feb 5, 2021
@kz33 kz33 deleted the fix-1131 branch February 5, 2021 06:34
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* fix issue kubeflow#1131

* format code and update README.md

* rebase and update chart version

* Trigger Build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants