-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helm: Put service account into pre-install hook. #1155
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
This enables users to install the chart using ArgoCD without setting special values. This solves kubeflow#1143 without requiring setting special values in values.yaml like the PR kubeflow#1145 requires.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the chart version.
We observed that since this webhook has been added, ArgoCD will re-create the serviceaccount on every sync. |
Hey would it be possible to add the corresponding argocd annotations alongside the helm annotations into the chart values? Right now I put these into my values file:
I noticed the there are a few 2 other resources with |
This enables users to install the chart using ArgoCD without setting special values. This solves kubeflow#1143 without requiring setting special values in values.yaml like the PR kubeflow#1145 requires.
This enables users to install the chart using ArgoCD without setting special values.
This solves #1143 without requiring setting special undocumented values in values.yaml like the PR #1145 requires.