Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Put service account into pre-install hook. #1155

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

tandrup
Copy link
Contributor

@tandrup tandrup commented Feb 5, 2021

This enables users to install the chart using ArgoCD without setting special values.

This solves #1143 without requiring setting special undocumented values in values.yaml like the PR #1145 requires.

@google-cla
Copy link

google-cla bot commented Feb 5, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@tandrup
Copy link
Contributor Author

tandrup commented Feb 5, 2021

@googlebot I signed it!

This enables users to install the chart using ArgoCD without setting special values.

This solves kubeflow#1143 without requiring setting special values in values.yaml like the PR kubeflow#1145 requires.
Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the chart version.

@liyinan926 liyinan926 merged commit 9788c1e into kubeflow:master Mar 7, 2021
@jgoeres
Copy link

jgoeres commented May 11, 2021

We observed that since this webhook has been added, ArgoCD will re-create the serviceaccount on every sync.
Did anyone else observe this, too? We are on a somewhat dated ArgoCD version v1.5.8+47f43f9 (and no, we cannot change that easily).

@domenicbove
Copy link

Hey would it be possible to add the corresponding argocd annotations alongside the helm annotations into the chart values?

Right now I put these into my values file:

  cleanupAnnotations:
    # These are the original helm hook annotations and their argocd mappings
    # "helm.sh/hook": pre-delete, pre-upgrade
    # "helm.sh/hook-delete-policy": hook-succeeded
    "argocd.argoproj.io/hook": PreSync
    "argocd.argoproj.io/hook-delete-policy": HookSucceeded

  initAnnotations:
    # These are the original helm hook annotations and their argocd mappings
    # "helm.sh/hook": pre-install, pre-upgrade
    # "helm.sh/hook-weight": "50"
    "argocd.argoproj.io/hook": PreSync
    "argocd.argoproj.io/sync-wave": "50"

I noticed the there are a few 2 other resources with helm.sh/hook annotations.

jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
This enables users to install the chart using ArgoCD without setting special values.

This solves kubeflow#1143 without requiring setting special values in values.yaml like the PR kubeflow#1145 requires.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants