Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom bucket path #1207

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Allow custom bucket path #1207

merged 1 commit into from
Mar 25, 2021

Conversation

bribroder
Copy link
Contributor

Presently, anything specified in the sparkctl parameter --upload-to which is not parsed as part of the host component of a URL gets silently dropped and a hard-coded value is used instead:

s3://test.bucket.io/a_prefix_for_my_app is parsed down to test.bucket.io and then /spark-app-dependencies gets added on the end.

This PR allows specifying a separate prefix component at the user's discretion with the --upload-prefix parameter:
--upload-to test.bucket.io --upload-prefix a_prefix_for_my_app

Allow specifying a prefix for bucket uploads
@google-cla
Copy link

google-cla bot commented Mar 24, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bribroder
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@liyinan926 liyinan926 merged commit fb4f23a into kubeflow:master Mar 25, 2021
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
Allow specifying a prefix for bucket uploads
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants