Add support for blue/green deployments #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flupke
commented
Apr 19, 2021
•
flupke
commented
- webhook certificate name is tied to release names
- add flags to control the deployment of the Role and ClusterRole separately
flupke
force-pushed
the
add-gencerts-resource-name
branch
from
2d69dd6
to
e08b793
Compare
flupke
changed the title
liyinan926
approved these changes
Apr 28, 2021
This is the first part of changes that will allow doing blue/green deployments of the Spark Operator.
This is the second part of changes allowing blue/green deployments of the Spark Operator: one can now deploy the ClusterRole without the Role, which would be defined in the common part of a blue/green deployment. Note this is a breaking change, so the chart version has been bumped to 2.
flupke
force-pushed
the
add-gencerts-resource-name
branch
from
e08b793
to
83689dc
Compare
Done. Please note that the chart comes with a breaking change and has been updated to 2.0.0 |
Is it possible to keep the variable |
|
Ok that's better indeed! how would I mark |
Probably just update the table in https://github.com/GoogleCloudPlatform/spark-on-k8s-operator/blob/master/charts/spark-operator-chart/README.md. |
liyinan926
reviewed
Apr 28, 2021
| | podSecurityContext | object | `{}` | Pod security context | | ||
| | rbac.create | bool | `true` | Create and use `rbac` resources | | ||
| | rbac.create | bool | `false` | DEPRECATED - use createRole and createClusterRole | |
There was a problem hiding this comment.
Nit: add ` around createRole and createClusterRole
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* Webhook certificate secrets name is tied to the release name This is the first part of changes that will allow doing blue/green deployments of the Spark Operator. * Split values' rbac.create flag in createRole and createClusterRole This is the second part of changes allowing blue/green deployments of the Spark Operator: one can now deploy the ClusterRole without the Role, which would be defined in the common part of a blue/green deployment. Note this is a breaking change, so the chart version has been bumped to 2. * fixup! Split values' rbac.create flag in createRole and createClusterRole * fixup! Split values' rbac.create flag in createRole and createClusterRole * fixup! Split values' rbac.create flag in createRole and createClusterRole
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.