Spelling #1231

jsoref · 2021-04-19T19:10:33Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@e647fad#commitcomment-49714646

The action reports that the changes in this PR would make it happy: jsoref@fd4491d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref · 2021-04-19T19:10:47Z

Makefile

@@ -27,7 +27,7 @@ install-sparkctl: | sparkctl/sparkctl-darwin-amd64 sparkctl/sparkctl-linux-amd64
 		sudo cp sparkctl/sparkctl-linux-amd64 /usr/local/bin/sparkctl; \
 		sudo chmod +x /usr/local/bin/sparkctl; \
 	elif [ "$(UNAME)" = "darwin" ]; then \
-		echo "installing macos binary to /usr/local/bin/sparkctl"; \
+		echo "installing macOS binary to /usr/local/bin/sparkctl"; \


jsoref · 2021-04-19T19:11:12Z

docs/gcp.md

@@ -14,7 +14,7 @@ The connectors require certain Hadoop properties to be set properly to function.
 both through a custom Hadoop configuration file, namely, `core-site.xml` in a custom image, or via the `spec.hadoopConf` 
 section in a `SparkApplication`. The example Dockerfile mentioned above shows the use of a custom `core-site.xml` and a 
 custom `spark-env.sh` that points the environment variable `HADOOP_CONF_DIR` to the directory in the container where 
-`core-site.xml` is located. The example `core-sitem.xml` and `spark-env.sh` can be found 
+`core-site.xml` is located. The example `core-site.xml` and `spark-env.sh` can be found 


jsoref · 2021-04-19T19:12:40Z

docs/gcp.md

@@ -14,7 +14,7 @@ The connectors require certain Hadoop properties to be set properly to function.
 both through a custom Hadoop configuration file, namely, `core-site.xml` in a custom image, or via the `spec.hadoopConf` 
 section in a `SparkApplication`. The example Dockerfile mentioned above shows the use of a custom `core-site.xml` and a 
 custom `spark-env.sh` that points the environment variable `HADOOP_CONF_DIR` to the directory in the container where 
-`core-site.xml` is located. The example `core-sitem.xml` and `spark-env.sh` can be found 
+`core-site.xml` is located. The example `core-site.xml` and `spark-env.sh` can be found 
 [here](https://github.com/GoogleCloudPlatform/spark-on-k8s-gcp-examples/tree/master/conf).


Note that here is not good style. https://www.w3.org/TR/WCAG20-TECHS/F84.html

I may at some point send a docs PR (it's really outside the scope of this PR, the whitespace change at the end of this is really out of scope too)

jsoref · 2021-04-19T19:13:14Z

docs/user-guide.md

@@ -447,7 +447,7 @@ Note that the mutating admission webhook is needed to use this feature. Please r
 ### Using Security Context

 A `SparkApplication` can specify a `SecurityContext` for the driver or executor containers, using the optional field `.spec.driver.securityContext` or `.spec.executor.securityContext`.
-`SparkApplication` can also specify a `PodSecurityContext` for the driver or executor pod, using the optional field `.spec.driver.PodsecurityContext` or `.spec.executor.PodsecurityContext`. Below is an example:
+`SparkApplication` can also specify a `PodSecurityContext` for the driver or executor pod, using the optional field `.spec.driver.podSecurityContext` or `.spec.executor.podSecurityContext`. Below is an example:


these reference an item 5 lines below

jsoref · 2021-04-19T19:13:34Z

docs/who-is-using.md

@@ -1,18 +1,18 @@
 ## Who Is Using the Kubernetes Operator for Apache Spark?

-| Organization | Contact (Github User Name) | Environment | Description of Use |
+| Organization | Contact (GitHub User Name) | Environment | Description of Use |


jsoref · 2021-04-19T19:13:55Z

docs/who-is-using.md

 | ------------- | ------------- | ------------- | ------------- |
 | [Caicloud](https://intl.caicloud.io/) | @gaocegege | Production | Cloud-Native AI Platform |
-| Microsoft (MileIQ) |@dharmeshkakadia| Production | AI & Analytics |
-| Lightbend |@yuchaoran2011| Production | Data Infrastructure & Operations |
+| Microsoft (MileIQ) | @dharmeshkakadia | Production | AI & Analytics |


The rest of these are whitespace. The file will not be checked by my tool going forward.

jsoref · 2021-04-19T19:15:01Z

pkg/controller/sparkapplication/controller.go

@@ -177,7 +177,7 @@ func (c *Controller) Stop() {
 // Callback function called when a new SparkApplication object gets created.
 func (c *Controller) onAdd(obj interface{}) {
 	app := obj.(*v1beta2.SparkApplication)
-	glog.Infof("SparkApplication %s/%s was added, enqueueing it for submission", app.Namespace, app.Name)
+	glog.Infof("SparkApplication %s/%s was added, enqueuing it for submission", app.Namespace, app.Name)


Both flavors are used in this corpus. Google Ngrams, enqueuing is winning.

jsoref · 2021-04-19T19:15:57Z

spark-docker/conf/prometheus.yaml

@@ -26,7 +26,7 @@ rules:
      app_namespace: "$1"
      app_id: "$2"
  # These come from the application driver if it's a structured streaming application
-  # Example: default/sstreaming.driver.spark.streaming.QueryName.inputRate-total
+  # Example: default/streaming.driver.spark.streaming.QueryName.inputRate-total


I'm assuming this is right

jsoref · 2021-04-19T19:16:08Z

sparkctl/cmd/client.go

@@ -32,7 +32,7 @@ import (
 func buildConfig(kubeConfig string) (*rest.Config, error) {
 	// Check if kubeConfig exist
 	if _, err := os.Stat(kubeConfig); os.IsNotExist(err) {
-		// Try InclusterConfig for sparkctl running in a pod
+		// Try InClusterConfig for sparkctl running in a pod


To match the next line

liyinan926 · 2021-04-20T16:36:33Z

Thanks for fixing those!

* spelling: additional Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: additionally Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: annotations Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: application Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: configuration Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: context Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: defaults Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: dependencies Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: details Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: enqueuing Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: existence Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: github Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: in-cluster Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: macos Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: metric Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: namespaces Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: optionally Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: package Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: period Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: podsecuritycontext Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: relative Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: scheduler Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: service Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: site Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: specifying Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: standard Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: streaming Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: successful Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: termination Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: unrelated Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: update Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * spelling: usage Signed-off-by: Josh Soref <jsoref@users.noreply.github.com> * Whitespace Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 30 commits April 19, 2021 14:22

spelling: additional

72bcaec

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: additionally

609b938

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: annotations

51856d1

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: application

bd596b0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: configuration

5751541

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: context

f417381

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: defaults

42c9c0c

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: dependencies

8d5a5f2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: details

14f33bc

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: enqueuing

a0bf11d

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: existence

e488535

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: github

70c8fa2

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: in-cluster

5ea1df5

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: macos

1cf8c23

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: metric

03c5422

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: namespaces

918b8a0

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: optionally

09d31a6

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: package

efc4d71

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: period

2b30c1a

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: podsecuritycontext

313ff02

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: relative

426a68b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: scheduler

92d916b

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: service

4155e87

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: site

0245cf3

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: specifying

a8b0aa4

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: standard

f7c9e34

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: streaming

51acb00

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: successful

04ca57f

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: termination

0a0d614

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: unrelated

f232236

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref added 3 commits April 19, 2021 15:04

spelling: update

b2a5850

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

spelling: usage

f178d05

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

Whitespace

ec38944

Signed-off-by: Josh Soref <jsoref@users.noreply.github.com>

jsoref commented Apr 19, 2021

View reviewed changes

liyinan926 merged commit 085fb68 into kubeflow:master Apr 20, 2021

jsoref deleted the spelling branch April 20, 2021 16:46

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #1231

Spelling #1231

jsoref commented Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

jsoref Apr 19, 2021

liyinan926 commented Apr 20, 2021

Spelling #1231

Spelling #1231

Conversation

jsoref commented Apr 19, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liyinan926 commented Apr 20, 2021