-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow user to specify service annotation on Spark UI service #1264
Allow user to specify service annotation on Spark UI service #1264
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the ℹ️ Googlers: Go here for more info. |
@googlebot I consent. |
b8c1712
to
d158dd9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please bump up the chart version and resolve the conflict.
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
c2669b8
to
d3f6f50
Compare
Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
Updated to 1.1.3, conflict resolved. |
…w#1264) * Allow user to specify service annotation on Spark UI service * Add service annotation in chart crd Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> * Bump chart version Signed-off-by: Khor Shu Heng <khor.heng@gojek.com> Co-authored-by: Khor Shu Heng <khor.heng@gojek.com>
Currently, there's no way to specify annotations on Spark UI services. One example of how this can be useful, is that we can add annotation on Spark UI services such that it can be ignored by Istio Pilot.