Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow user to specify service annotation on Spark UI service #1264

Merged
merged 3 commits into from
May 25, 2021

Conversation

khorshuheng
Copy link
Contributor

Currently, there's no way to specify annotations on Spark UI services. One example of how this can be useful, is that we can add annotation on Spark UI services such that it can be ignored by Istio Pilot.

@google-cla
Copy link

google-cla bot commented May 18, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@khorshuheng
Copy link
Contributor Author

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented May 18, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@khorshuheng
Copy link
Contributor Author

@googlebot I consent.

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump up the chart version and resolve the conflict.

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>
@khorshuheng
Copy link
Contributor Author

Please bump up the chart version and resolve the conflict.

Updated to 1.1.3, conflict resolved.

@liyinan926 liyinan926 merged commit a123efd into kubeflow:master May 25, 2021
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
…w#1264)

* Allow user to specify service annotation on Spark UI service

* Add service annotation in chart crd

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>

* Bump chart version

Signed-off-by: Khor Shu Heng <khor.heng@gojek.com>

Co-authored-by: Khor Shu Heng <khor.heng@gojek.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants