Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add user defined pod labels #1288

Merged
merged 3 commits into from
Jul 28, 2021
Merged

Conversation

pdrastil
Copy link
Contributor

This adds the ability to define user labels on Spark operator pod. Main use case is integration with external logging solution. Please let me know if I should bump chart version in the PR or if you manage release cycle for the chart. Thanks

@google-cla
Copy link

google-cla bot commented Jun 29, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pdrastil
Copy link
Contributor Author

@googlebot I signed it!

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the Chart readme and also bump the chart version?

@pdrastil
Copy link
Contributor Author

pdrastil commented Jul 1, 2021

Updated README and minor chart version.

@pdrastil
Copy link
Contributor Author

@liyinan926 Hi, can you please check what's with your test cluster that is used for pre-commit checks? It seems that scheduler cannot find any nodes for spark-operator.

@liyinan926 liyinan926 merged commit e3ed251 into kubeflow:master Jul 28, 2021
@pdrastil pdrastil deleted the feature/labels branch July 30, 2021 14:15
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
* Add user defined pod labels

* Update README.md

* Bump chart version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants