Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CRDs from v1beta1 to v1. Add additionalPrinterColumns #1298

Merged
merged 4 commits into from
Jul 25, 2021

Conversation

drazul
Copy link
Contributor

@drazul drazul commented Jul 7, 2021

Hi,

I migrated both CRDs to v1 inspired on PR #1258 But editing the schema to fit the new api version.

I also added new columns to be shown with kubectl get.

$ kubectl get scheduledsparkapplication

NAME                   SCHEDULE      SUSPEND   LAST RUN   LAST RUN NAME                              AGE
snapshot-gen-feature   0 0 * * THU   false     6d11h      snapshot-gen-feature-1625097621612205851   8d

$ kubectl get sparkapplication

NAME                                       STATUS      ATTEMPTS   START                  FINISH                 AGE
snapshot-gen-feature-1625097621612205851   COMPLETED   1          2021-07-01T00:00:26Z   2021-07-01T01:08:15Z   6d11h

Note: I didn't find a way to make an operation on CRD additionalPrinterColumns to replace start and finish time columns with duration column

@google-cla
Copy link

google-cla bot commented Jul 7, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drazul
Copy link
Contributor Author

drazul commented Jul 8, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jul 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drazul
Copy link
Contributor Author

drazul commented Jul 8, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jul 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drazul
Copy link
Contributor Author

drazul commented Jul 8, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jul 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
@google-cla
Copy link

google-cla bot commented Jul 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drazul
Copy link
Contributor Author

drazul commented Jul 8, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jul 8, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drazul
Copy link
Contributor Author

drazul commented Jul 9, 2021

@googlebot I signed it!

@google-cla
Copy link

google-cla bot commented Jul 9, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@drazul
Copy link
Contributor Author

drazul commented Jul 12, 2021

@googlebot I signed it!

Copy link
Collaborator

@liyinan926 liyinan926 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update the CRD yamls under manifest?

Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
@drazul
Copy link
Contributor Author

drazul commented Jul 20, 2021

@liyinan926 Done

@drazul
Copy link
Contributor Author

drazul commented Jul 22, 2021

CI error is pointing to this Kubernetes PR kubernetes/enhancements#1111

I guess this new check is only applicable for CRD api v1 and not for v1beta1 and that is why it pass on other builds.

That PR says we should not use CRD groups k8s.io or kubernetes.io as they are reserved for the Official Kubernetes Community.

This will take some time to refactor so I will add an annotation to the CRD to bypass that limitation.

… k8s.io or kubernetes.io kubernetes/enhancements#1111

Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
@drazul drazul requested a review from liyinan926 July 22, 2021 09:20
@liyinan926 liyinan926 merged commit 5c87fcc into kubeflow:master Jul 25, 2021
jbhalodia-slack pushed a commit to jbhalodia-slack/spark-operator that referenced this pull request Oct 4, 2024
…ow#1298)

* Migrate Spark CRDs from v1beta1 to v1

Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>

* Add extra printer columns for CRDs. Bump chart version

Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>

* Update CRDs definition files on app manifest

Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>

* Add annotation on CRDs to ignore the new policy to not use CRD groups k8s.io or kubernetes.io kubernetes/enhancements#1111

Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants