-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate CRDs from v1beta1 to v1. Add additionalPrinterColumns #1298
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
@googlebot I signed it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also update the CRD yamls under manifest
?
Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
@liyinan926 Done |
CI error is pointing to this Kubernetes PR kubernetes/enhancements#1111 I guess this new check is only applicable for CRD api v1 and not for v1beta1 and that is why it pass on other builds. That PR says we should not use CRD groups k8s.io or kubernetes.io as they are reserved for the Official Kubernetes Community. This will take some time to refactor so I will add an annotation to the CRD to bypass that limitation. |
… k8s.io or kubernetes.io kubernetes/enhancements#1111 Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
…ow#1298) * Migrate Spark CRDs from v1beta1 to v1 Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com> * Add extra printer columns for CRDs. Bump chart version Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com> * Update CRDs definition files on app manifest Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com> * Add annotation on CRDs to ignore the new policy to not use CRD groups k8s.io or kubernetes.io kubernetes/enhancements#1111 Signed-off-by: Daniel AguadoAraujo <daniel.aguadoaraujo@gfk.com>
Hi,
I migrated both CRDs to v1 inspired on PR #1258 But editing the schema to fit the new api version.
I also added new columns to be shown with kubectl get.
$ kubectl get scheduledsparkapplication
$ kubectl get sparkapplication
Note: I didn't find a way to make an operation on CRD additionalPrinterColumns to replace
start
andfinish
time columns withduration
column