Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make manifests usable by Kustomize #1367

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

karpoftea
Copy link
Contributor

  1. Group manifests by purpose
  2. Add kustomization.yaml for each group to benefit for users that prefer Kustomize
  3. Move examples to appropriate folder

@google-cla
Copy link

google-cla bot commented Oct 12, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@karpoftea
Copy link
Contributor Author

@googlebot I fixed it.

@liyinan926
Copy link
Collaborator

I think somehow we need to disable one of the check for CRD drift between manifest and the chart folder.

@karpoftea
Copy link
Contributor Author

I think somehow we need to disable one of the check for CRD drift between manifest and the chart folder.

thanks! i'll see what i can do and submit a change

@google-cla
Copy link

google-cla bot commented Oct 25, 2021

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@karpoftea
Copy link
Contributor Author

I've simply added --exclude=kustomization.yaml to diff expression in order to exclude kustomization manifest from CRD drift check

@liyinan926 liyinan926 merged commit a010501 into kubeflow:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants