delete-service-accounts-and-roles-before-creation #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please bump up the chart version. |
TiansuYu
force-pushed
the
delete-service-accounts-and-roles-before-creation
branch
from
73f2c88
to
ec9c886
Compare
|
rebased with main to solve version conflicts issue |
TiansuYu
deleted the
delete-service-accounts-and-roles-before-creation
branch
jbhalodia-slack
pushed a commit
to jbhalodia-slack/spark-operator
that referenced
this pull request
Oct 4, 2024
* delete-service-accounts-and-roles-before-creation * bump spark-operator version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with issue #1359
The current version of helm chart does not handle hook tearing-down automatically. So after the uninstall,
spark-operatorwill leave three artifactsserviceAccount,ClusterRoleandClusterRoleBindinginside the k8s config. Attempts to reinstall the samespark-operatorwill be blocked becauserbac.yamlwill try to install these as pre-install hook, despite the fact that they are already there.Suggest to add the
before-hook-creationinsidehook-delete-policyas suggested by @swartz-k, to fix this issue.